Replace mock vault approach with real filesystem I/O for integration
tests. Each test copies tests/fixtures/test-vault/ to a temp directory,
overrides mock handlers to point at it, and verifies actual file
operations through the vite dev server middleware.
Tests cover: vault loading, archive/trash filtering, note creation,
rename with filesystem update, wikilink cascade on rename, relationship
display, and real file content loading.
Also extends vite.config.ts vault API middleware with write endpoints
(save, rename, delete, search, entry) and fixes getBool to handle
YAML 1.2 string values like "Yes"/"yes" (js-yaml 4.x compatibility).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Title sync now triggers a full rename flow instead of in-memory update,
so the Cmd+S test expectations needed updating.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- handleRenameNote passes entry title as old_title to Rust
- handleUpdateFrontmatter triggers rename on title key change
- non-title keys don't trigger rename
- null old_title when entry not found
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
handleTitleSync now saves pending content and calls rename_note
(which renames the file and updates wikilinks) instead of only
updating in-memory state. handleUpdateFrontmatter also triggers
rename when the title: key is changed.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the editor saves content with a new H1 before triggering rename,
the on-disk H1 already matches the new title, causing rename_note to
noop. The old_title_hint parameter lets the caller provide the
original title so wikilinks are still found and updated.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies tight lists stay tight, headings don't gain extra blank lines,
and saving without editing doesn't add whitespace changes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
blocksToMarkdownLossy() inserts blank lines between every block, making
tight lists loose and polluting git history. Add compactMarkdown() that
collapses inter-list-item blanks and excessive blank line runs while
preserving code blocks and intentional paragraph spacing.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Test [[ autocomplete inserts wikilink with correct data-target attribute
- Test inserted wikilink does not show as broken (correct color resolution)
- Test clicking inserted wikilink navigates to the correct note
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Create resolveEntry() in wikilink.ts: single case-insensitive resolution
function that handles title, alias, filename stem, path suffix, and
pipe syntax matching
- Replace findEntryByTarget (case-sensitive) and entryMatchesTarget
(hardcoded /Laputa/ path) with unified resolveEntry
- Fix attachClickHandlers to insert path|title pipe syntax when multiple
candidates share the same title (disambiguation)
- Update ai-context.ts resolveTarget to use unified resolution
- Add comprehensive tests for resolveEntry and disambiguation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove setIsDragOver(true) from Tauri onDragDropEvent 'over' handler —
Tauri over events can't distinguish OS file drags from internal drags.
The HTML5 dragover handler already checks hasImageFiles() correctly and
now solely drives the overlay state. Tauri handler only processes drops.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers: title change + save renames file, no rename when filename matches,
rapid title edits rename to final title.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When Cmd+S is pressed, after saving content, checks if the note's
title slug differs from its current filename. If so, triggers
rename_note to update the file on disk, tabs, breadcrumbs, and
wikilinks. Adds needsRenameOnSave() utility with tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the note content already has the correct title but the filename
doesn't match (e.g. untitled-note-9.md after user changed H1), the
rename was a no-op. Now checks both title AND filename slug before
early-returning. Also uses unique_dest_path for collision handling.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies that changing a note's type preserves the editor content —
the bug caused the tab to load a different note's content after the move.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The mock handler now appends -2, -3, etc. when the target path already
exists, matching the Rust unique_dest_path logic. Previously it would
silently overwrite the existing note's content in MOCK_CONTENT.
Also adds a Rust test that verifies both the moved note and the
pre-existing note retain their respective content after a collision.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
After runFrontmatterOp updates the frontmatter and sets the tab content,
move_note_to_type_folder only changes the file location (not its content).
Re-reading via loadNoteContent(result.new_path) was redundant and dangerous:
if the path collided or a stale cache intervened, it could load a different
note's content into the tab — the root cause of the data-corruption bug.
Also fixes stale-closure issue: replaceEntry no longer spreads the captured
`entries` array (which could be stale after the await), avoiding reverting
the isA field that runFrontmatterOp already updated.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Root cause: commit d6d35b3 added a custom Rust deserializer for
Archived/Trashed Yes/No strings but did not bump CACHE_VERSION.
Existing vaults had stale cached entries with archived: false from the
old parser, and since the cache version (5) matched, stale values were
served without re-parsing from disk.
- Bump CACHE_VERSION 5 → 6 to force full rescan on next vault load
- Add Yes/No handling to TypeScript parseScalar (Inspector display)
- Add integration tests: cached vault path with Archived/Trashed: Yes
- Add stale cache version invalidation test
- Add frontmatter.test.ts for TS Yes/No boolean parsing
- Add Playwright smoke test for archived note filtering
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers all acceptance criteria:
- Click '+' next to type section → note created, no crash
- Cmd+N → note created, no crash
- Custom type → note created, no crash
- Rapid double-click → both notes created, no crash
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- slugify now returns 'untitled' instead of empty string when input has only
special characters, preventing invalid paths like '/vault//note.md'
- handleCreateNoteImmediate wrapped in try/catch — worst case shows a toast
error instead of crashing the app
- Added Rust test for deeply nested directory creation in save_note_content
- Regression tests for slugify edge cases and handleCreateNoteImmediate with
special-character types
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies that editing a theme note frontmatter in raw mode and pressing
Ctrl+S immediately updates CSS vars on the DOM. Also verifies saving a
non-theme note does not affect the active theme.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When user edits a theme note directly in the editor and presses Cmd+S,
the app now immediately re-applies CSS variables — no manual reload
needed. Added notifyThemeSaved(path, content) to ThemeManager; wired
into onNotePersisted callback so saving the active theme updates
cachedThemeContent, triggering useThemeApplier.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Validates that rapid keyboard navigation and click-based note switching
don't produce stale content or crash the editor.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Prefetch: content served from cache, cache cleared on vault reload,
deduplication of concurrent requests
- Optimistic rollback: trash/archive/restore/unarchive roll back
updateEntry on disk write failure with error toast
- Optimistic ordering: updateEntry called before frontmatter writes
- Rapid switching: sequence counter prevents stale active tab when
notes are opened faster than IPC resolves
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Latency root causes:
1. handleSelectNote/handleReplaceActiveTab awaited IPC before updating
activeTabPath — zero visual feedback for 50-200ms file I/O
2. Trash/archive called updateEntry AFTER two sequential IPC calls —
note stayed visible in list for 100-400ms
Optimizations:
- Content prefetch cache: hover on NoteItem and keyboard arrow
navigation pre-load note content via IPC. When user clicks, content is
already in memory — eliminates the IPC round-trip entirely.
- Optimistic trash/archive/restore/unarchive: updateEntry runs
immediately, frontmatter writes happen async. On failure, UI rolls
back and shows error toast.
- Rapid-switch safety: sequence counter (navSeqRef) ensures only the
latest navigation sets activeTabPath — prevents stale content flash
when user clicks multiple notes in quick succession.
- Prefetch cache cleared on vault reload to prevent stale content after
external edits.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `span.truncate` selector was matching sidebar note titles in addition
to search results, causing false positives in the full-text search test.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trashed notes were appearing in search (Cmd+F), Quick Open (Ctrl+P),
wikilink autocomplete ([[), and person mention autocomplete (@).
Rust: add is_file_trashed() to check frontmatter, filter search_vault results.
Frontend: filter trashed entries from useNoteSearch, baseItems in both
editor views, and mock search_vault handler.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Rust YAML parser only accepted boolean values (true/false) for the
archived and trashed fields. When the vault writes Archived: Yes or
Trashed: Yes (YAML string, not boolean), serde silently returned None
and the note appeared as non-archived/non-trashed.
Add a custom deserializer that accepts both booleans and string
representations (Yes/yes/YES/true/1 → true, No/no/false/0 → false).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The vault-api proxy maps Tauri commands to HTTP endpoints when a vault
API server is running. Without this, reload_vault bypassed the proxy
and Playwright route interceptors couldn't catch vault reload calls.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reload Vault (Cmd+K) now calls the new `reload_vault` Tauri command which
deletes the cache file before scanning, guaranteeing a full filesystem
rescan. Previously it called `list_vault` which used incremental git-based
cache updates that could miss recent changes (e.g. trashing a note then
reloading showed stale data).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use untyped function references to avoid conflicts with
posAtCoords overloaded type signatures.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers clicking at 150%, 80%, and double-click word selection at 125%.
Verifies cursor lands near the click point (within first 30 chars of line)
and that word selection produces a non-empty range.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CSS zoom on document.documentElement causes a coordinate space mismatch
between mouse event clientX/Y (viewport space) and Range.getClientRects()
(CSS space), breaking CodeMirror's click-to-position mapping. The previous
requestMeasure() fix only recalibrated cached geometry, not this mismatch.
New approach: zoomCursorFix extension patches posAtCoords/posAndSideAtCoords
on the EditorView instance to use document.caretRangeFromPoint() — the
browser's native, zoom-aware API — with coord-adjustment fallback.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The AI chat panel (AiPanel → useAiAgent) was sending each message as a
standalone request with no prior context. Root cause: useAiAgent.sendMessage
called streamClaudeAgent with raw text, never embedding history.
- Add agentMessagesToChatHistory() to convert AiAgentMessage[] to ChatMessage[]
- Embed trimmed history in each agent request via formatMessageWithHistory
- Use messagesRef/statusRef to avoid stale closures in async callbacks
- Also fix useAIChat (dead code path) with same ref pattern
- Update mock layers to detect history presence for testability
- Add Playwright smoke tests verifying history accumulates and resets
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Settings command is disabled in mock environment (onOpenSettings not wired),
causing the 'typing filters the command list' test to always fail.
Reindex Vault is always enabled and already tested in indexing-reindex-status.spec.ts.
Remove the early return in update_same_commit that skipped filesystem
validation when git reported no changes. Add prune_stale_entries to
finalize_and_cache so every vault scan path validates entries exist on
disk and deduplicates by case-folded path. Prevents ghost notes after
deleting files outside the app (e.g., via Finder).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move updateEntry() calls after handleUpdateFrontmatter/handleDeleteProperty
in handleCustomizeType, handleRenameSection, and handleToggleTypeVisibility
so React state only updates after the disk write succeeds. This prevents
state-disk divergence when writes fail.
Expand ARCHITECTURE.md "Three representations, one authority" section with
ownership rules, invariants table, and recovery mechanisms. Add
reload_vault_entry to the commands table (62 total).
Add Playwright smoke test for Reload Vault in Cmd+K palette.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a "Reload Vault" command that forces a full rescan from filesystem,
bypassing cache. Available via Cmd+K and Vault menu. Wired through
useAppCommands → useCommandRegistry and useMenuEvents.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
