davidl/tolaria
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: scope Playwright selectors to dialog overlays to avoid sidebar matches

Browse Source 
The `span.truncate` selector was matching sidebar note titles in addition
to search results, causing false positives in the full-text search test.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
lucaronin
2026-03-09 12:59:57 +01:00
parent a760594d66
commit db66e7c9da
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/smoke/exclude-trashed-from-search.spec.ts
View File

@@ -15,8 +15,19 @@ async function openQuickOpen(page: import('@playwright/test').Page) {
await expect(page.locator(QUICK_OPEN_INPUT)).toBeVisible()
}
function getAllResultTitles(page: import('@playwright/test').Page) {
return page.locator('span.truncate').allTextContents()
/** Get result titles scoped to a specific container (avoids matching sidebar items). */
function getResultTitles(container: import('@playwright/test').Locator) {
return container.locator('span.truncate').allTextContents()
}
/** The Quick Open dialog overlay */
function quickOpenPanel(page: import('@playwright/test').Page) {
return page.locator('.fixed.inset-0').filter({ has: page.locator(QUICK_OPEN_INPUT) })
}
/** The full-text search dialog overlay */
function searchPanel(page: import('@playwright/test').Page) {
return page.locator('.fixed.inset-0').filter({ has: page.locator(SEARCH_INPUT) })
}
test.describe('Exclude trashed notes from search and autocomplete', () => {
@@ -27,21 +38,23 @@ test.describe('Exclude trashed notes from search and autocomplete', () => {
test('trashed notes do not appear in Quick Open search', async ({ page }) => {
await openQuickOpen(page)
const panel = quickOpenPanel(page)
for (const title of TRASHED_TITLES) {
// Use a unique enough substring to trigger results
const query = title.split(' ')[0]
await page.locator(QUICK_OPEN_INPUT).fill(query)
await page.waitForTimeout(400)
const titles = await getAllResultTitles(page)
const titles = await getResultTitles(panel)
expect(titles, `"${title}" should not appear for query "${query}"`).not.toContain(title)
}
})
test('active notes still appear in Quick Open search', async ({ page }) => {
await openQuickOpen(page)
const panel = quickOpenPanel(page)
await page.locator(QUICK_OPEN_INPUT).fill(ACTIVE_QUERY)
await page.waitForTimeout(400)
const titles = await getAllResultTitles(page)
const titles = await getResultTitles(panel)
expect(titles.some(t => t.includes('Laputa App'))).toBe(true)
})
@@ -67,7 +80,7 @@ test.describe('Exclude trashed notes from search and autocomplete', () => {
}
await page.locator(SEARCH_INPUT).fill('Old Draft')
await page.waitForTimeout(600)
const titles = await getAllResultTitles(page)
const titles = await getResultTitles(searchPanel(page))
expect(titles).not.toContain('Old Draft Notes')
})