Compare commits

...

3 Commits

Author SHA1 Message Date
Test
24e5b537d6 fix: wikilink autocomplete in FilterBuilder no longer clipped by dialog
The dropdown was position:absolute inside a scrollable container with
overflow-y:auto, causing it to be clipped. Now uses createPortal to
render to document.body with position:fixed, escaping the dialog's
overflow. Also adds proper CSS for menu items (font-size 12px, aligned
icon+text, compact padding) via .wikilink-menu--filter modifier.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-05 11:58:08 +02:00
Test
f8f6e3d003 fix: always show note title in breadcrumb bar when raw/diff mode active
Use prop-driven data-title-hidden attribute in BreadcrumbBar when rawMode or
diffMode is true. This avoids the timing issue where the useEffect DOM mutation
fired after paint with a null ref, causing the title to never appear.

The IntersectionObserver-based scroll detection is preserved for normal editor
mode (title shows in breadcrumb when title section scrolls out of view).
2026-04-05 11:07:53 +02:00
Test
ba9b5c7c31 fix: make Select scroll buttons functional by using overflow-hidden on Content
The SelectContent had overflow-y-auto which caused the browser to handle
scrolling instead of Radix UI's internal scroll mechanism. This made the
SelectScrollDownButton (chevron ▼) non-functional. Changing to
overflow-hidden lets Radix's Viewport manage scrolling, making the
scroll buttons work as intended.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-05 11:07:02 +02:00
5 changed files with 81 additions and 19 deletions

View File

@@ -204,10 +204,14 @@ function BreadcrumbTitle({ entry }: { entry: VaultEntry }) {
export const BreadcrumbBar = memo(function BreadcrumbBar({
entry, barRef, ...actionProps
}: BreadcrumbBarProps) {
// In raw/diff mode the title section is not rendered — always show title in breadcrumb.
// Using a prop-driven attribute avoids the timing issues of DOM mutation in useEffect.
const titleAlwaysVisible = actionProps.rawMode || actionProps.diffMode
return (
<div
ref={barRef}
data-tauri-drag-region
{...(titleAlwaysVisible ? { 'data-title-hidden': '' } : {})}
className="breadcrumb-bar flex shrink-0 items-center"
style={{
height: 52,

View File

@@ -182,19 +182,16 @@ export function EditorContent({
const titleSectionRef = useRef<HTMLDivElement | null>(null)
const breadcrumbBarRef = useRef<HTMLDivElement | null>(null)
// When in normal editor mode: use IntersectionObserver to show/hide the breadcrumb title
// based on whether the title section has scrolled out of view.
// In raw/diff mode, BreadcrumbBar handles title visibility via its rawMode/diffMode props.
useEffect(() => {
if (!showEditor) return
const bar = breadcrumbBarRef.current
if (!bar) return
// In raw/diff mode the title section is not rendered, so there is nothing
// for the IntersectionObserver to watch. Force the title visible instead.
if (!showEditor) {
bar.setAttribute('data-title-hidden', '')
return () => { bar.removeAttribute('data-title-hidden') }
}
const el = titleSectionRef.current
if (!el) return
if (!bar || !el) return
const observer = new IntersectionObserver(
([e]) => {
if (e.isIntersecting) bar.removeAttribute('data-title-hidden')

View File

@@ -1,4 +1,5 @@
import { useState, useRef, useMemo, useEffect, useCallback } from 'react'
import { createPortal } from 'react-dom'
import { Plus, X, CalendarBlank } from '@phosphor-icons/react'
import { format, parseISO } from 'date-fns'
import { Button } from '@/components/ui/button'
@@ -146,18 +147,30 @@ function useOutsideClick(refs: React.RefObject<HTMLElement | null>[], onClose: (
}, [refs, onClose])
}
function WikilinkDropdown({ matches, selectedIndex, onSelect, onHover, menuRef }: {
function WikilinkDropdown({ matches, selectedIndex, onSelect, onHover, menuRef, anchorRef }: {
matches: WikilinkMatch[]
selectedIndex: number
onSelect: (title: string) => void
onHover: (index: number) => void
menuRef: React.RefObject<HTMLDivElement | null>
anchorRef: React.RefObject<HTMLElement | null>
}) {
return (
const [pos, setPos] = useState<{ top: number; left: number; width: number } | null>(null)
useEffect(() => {
const el = anchorRef.current
if (!el) return
const rect = el.getBoundingClientRect()
setPos({ top: rect.bottom + 2, left: rect.left, width: rect.width })
}, [anchorRef, matches])
if (!pos) return null
return createPortal(
<div
className="wikilink-menu"
className="wikilink-menu wikilink-menu--filter"
ref={menuRef}
style={{ position: 'absolute', top: '100%', left: 0, right: 0, marginTop: 2, zIndex: 50 }}
style={{ position: 'fixed', top: pos.top, left: pos.left, width: pos.width }}
data-testid="wikilink-dropdown"
>
{matches.map((item, index) => (
@@ -169,17 +182,18 @@ function WikilinkDropdown({ matches, selectedIndex, onSelect, onHover, menuRef }
onMouseEnter={() => onHover(index)}
>
<span className="wikilink-menu__title" style={{ display: 'flex', alignItems: 'center', gap: 6 }}>
{item.TypeIcon && <item.TypeIcon width={14} height={14} style={{ color: item.typeColor, flexShrink: 0 }} />}
{item.TypeIcon && <item.TypeIcon width={12} height={12} style={{ color: item.typeColor, flexShrink: 0 }} />}
{item.title}
</span>
{item.noteType && (
<span className="wikilink-menu__type" style={{ color: item.typeColor, backgroundColor: item.typeLightColor, borderRadius: 9999, padding: '1px 8px' }}>
<span className="wikilink-menu__type" style={{ color: item.typeColor, backgroundColor: item.typeLightColor, borderRadius: 9999, padding: '1px 6px' }}>
{item.noteType}
</span>
)}
</div>
))}
</div>
</div>,
document.body,
)
}
@@ -261,7 +275,7 @@ function WikilinkValueInput({ value, entries, onChange }: {
}, [onChange, resetIndex])
return (
<div style={{ position: 'relative' }} className="flex-1 min-w-0">
<div className="flex-1 min-w-0">
<Input
ref={inputRef}
className="h-8 w-full text-sm"
@@ -279,6 +293,7 @@ function WikilinkValueInput({ value, entries, onChange }: {
onSelect={handleSelect}
onHover={setSelectedIndex}
menuRef={menuRef}
anchorRef={inputRef}
/>
)}
</div>

View File

@@ -10,3 +10,49 @@
max-width: 400px;
z-index: 9999;
}
.wikilink-menu__item {
display: flex;
align-items: center;
justify-content: space-between;
gap: 8px;
padding: 5px 8px;
cursor: pointer;
font-size: 13px;
line-height: 1.4;
}
.wikilink-menu__item:hover,
.wikilink-menu__item--selected {
background: hsl(var(--accent));
}
.wikilink-menu__title {
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
min-width: 0;
}
.wikilink-menu__type {
flex-shrink: 0;
font-size: 10px;
line-height: 1.4;
white-space: nowrap;
}
/* Compact variant for FilterBuilder inside dialogs */
.wikilink-menu--filter {
font-size: 12px;
max-height: 240px;
overflow-y: auto;
}
.wikilink-menu--filter .wikilink-menu__item {
padding: 4px 8px;
font-size: 12px;
}
.wikilink-menu--filter .wikilink-menu__type {
font-size: 10px;
}

View File

@@ -61,7 +61,7 @@ function SelectContent({
<SelectPrimitive.Content
data-slot="select-content"
className={cn(
"bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 relative z-[12000] max-h-(--radix-select-content-available-height) min-w-[8rem] origin-(--radix-select-content-transform-origin) overflow-x-hidden overflow-y-auto rounded-md border shadow-md",
"bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 relative z-[12000] max-h-(--radix-select-content-available-height) min-w-[8rem] origin-(--radix-select-content-transform-origin) overflow-x-hidden overflow-hidden rounded-md border shadow-md",
position === "popper" &&
"data-[side=bottom]:translate-y-1 data-[side=left]:-translate-x-1 data-[side=right]:translate-x-1 data-[side=top]:-translate-y-1",
className