davidl/tolaria
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: make Restore Default Themes command always enabled in Cmd+K palette

Browse Source 
The enabled guard `!!onRestoreDefaultThemes` could evaluate to false at
runtime, hiding the command from the palette. Since the handler is always
defined via useCallback, the guard is unnecessary. Changed to enabled: true,
matching the pattern used by other always-available commands.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
lucaronin
2026-03-05 12:30:38 +01:00
parent 85234b1b98
commit da01d2ec28
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/hooks/useCommandRegistry.test.ts
View File

@@ -715,11 +715,11 @@ describe('useCommandRegistry', () => {
expect(cmd!.enabled).toBe(true)
})
it('is disabled when onRestoreDefaultThemes is not provided', () => {
it('is always enabled even when onRestoreDefaultThemes is not provided', () => {
const { result } = renderHook(() => useCommandRegistry(makeConfig()))
const cmd = result.current.find(c => c.id === 'restore-default-themes')
expect(cmd).toBeDefined()
expect(cmd!.enabled).toBe(false)
expect(cmd!.enabled).toBe(true)
})
it('calls onRestoreDefaultThemes when executed', () => {

2
src/hooks/useCommandRegistry.ts
View File

@@ -249,7 +249,7 @@ export function useCommandRegistry(config: CommandRegistryConfig): CommandAction
// Appearance
...buildThemeCommands(themes, activeThemeId, onSwitchTheme, onCreateTheme, onOpenTheme),
{ id: 'restore-default-themes', label: 'Restore Default Themes', group: 'Appearance', keywords: ['theme', 'reset', 'restore', 'default', 'fix', 'missing'], enabled: !!onRestoreDefaultThemes, execute: () => onRestoreDefaultThemes?.() },
{ id: 'restore-default-themes', label: 'Restore Default Themes', group: 'Appearance', keywords: ['theme', 'reset', 'restore', 'default', 'fix', 'missing'], enabled: true, execute: () => onRestoreDefaultThemes?.() },
// Settings
{ id: 'open-settings', label: 'Open Settings', group: 'Settings', shortcut: '⌘,', keywords: ['preferences', 'config'], enabled: true, execute: onOpenSettings },