davidl/tolaria
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove duplicate type icon in add-property input (#107)

Browse Source 
SelectValue already renders the icon from the selected SelectItem,
so the explicit Icon in SelectTrigger caused the type icon to appear twice.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Luca Rossi
2026-02-27 12:12:58 +01:00
committed by GitHub
parent 82b60f1349
commit cdb9de59bb
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/DynamicPropertiesPanel.tsx
View File

@@ -8,10 +8,9 @@ import { Button } from '@/components/ui/button'
import { Calendar } from '@/components/ui/calendar'
import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover'
import { Select, SelectContent, SelectItem, SelectSeparator, SelectTrigger, SelectValue } from '@/components/ui/select'
import { CalendarIcon, XIcon } from 'lucide-react'
import { CalendarIcon, XIcon, Check, X, Type, ToggleLeft, Circle, Link } from 'lucide-react'
import { getTypeColor, getTypeLightColor } from '../utils/typeColors'
import { countWords } from '../utils/wikilinks'
import { Check, X, Type, Calendar as CalendarIcon2, ToggleLeft, Circle, Link } from 'lucide-react'
import {
type PropertyDisplayMode,
getEffectiveDisplayMode,
@@ -237,7 +236,7 @@ function DisplayModeSelector({ propKey, currentMode, autoMode, onSelect }: {
}
const DISPLAY_MODE_ICONS: Record<PropertyDisplayMode, typeof Type> = {
text: Type, date: CalendarIcon2, boolean: ToggleLeft, status: Circle, url: Link,
text: Type, date: CalendarIcon, boolean: ToggleLeft, status: Circle, url: Link,
}
function AddPropertyForm({ onAdd, onCancel }: {
@@ -252,8 +251,6 @@ function AddPropertyForm({ onAdd, onCancel }: {
else if (e.key === 'Escape') onCancel()
}
const Icon = DISPLAY_MODE_ICONS[displayMode]
return (
<div className="mt-1 flex items-center gap-1.5 rounded px-1.5 py-1" data-testid="add-property-form">
<input
@@ -268,7 +265,6 @@ function AddPropertyForm({ onAdd, onCancel }: {
style={{ fontSize: 12, borderRadius: 4 }}
data-testid="add-property-type-trigger"
>
<Icon className="size-3 shrink-0 text-muted-foreground" />
<SelectValue />
</SelectTrigger>
<SelectContent>