fix: show type icon and label for "Note" type in search and autocomplete
The "Note" type was explicitly filtered out with `isA !== 'Note'` in SearchPanel, NoteAutocomplete, and useNoteSearch, preventing its icon and label from appearing. Remove this special-casing so all types display consistently. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -37,7 +37,7 @@ function matchEntries(entries: VaultEntry[], typeEntryMap: Record<string, VaultE
|
||||
return matches.slice(0, MAX_RESULTS).map(e => {
|
||||
const isA = e.isA
|
||||
const te = typeEntryMap[isA ?? '']
|
||||
const noteType = isA && isA !== 'Note' ? isA : undefined
|
||||
const noteType = isA || undefined
|
||||
return {
|
||||
title: e.title,
|
||||
noteType,
|
||||
|
||||
@@ -193,7 +193,7 @@ function SearchContent({
|
||||
{results.map((result, i) => {
|
||||
const entry = entryLookup.get(result.path)
|
||||
const isA = entry?.isA ?? result.noteType
|
||||
const noteType = isA && isA !== 'Note' ? isA : null
|
||||
const noteType = isA || null
|
||||
const te = typeEntryMap[isA ?? '']
|
||||
const typeColor = noteType ? getTypeColor(isA, te?.color) : undefined
|
||||
const TypeIcon = getTypeIcon(isA ?? null, te?.icon)
|
||||
|
||||
@@ -69,12 +69,12 @@ describe('useNoteSearch', () => {
|
||||
expect(project?.typeLightColor).toBeTruthy()
|
||||
})
|
||||
|
||||
it('excludes noteType and light color for Note entries', () => {
|
||||
it('includes noteType and colors for Note entries', () => {
|
||||
const { result } = renderHook(() => useNoteSearch(entries, ''))
|
||||
const note = result.current.results.find((r) => r.title === 'Beta Notes')
|
||||
expect(note?.noteType).toBeUndefined()
|
||||
expect(note?.typeColor).toBeUndefined()
|
||||
expect(note?.typeLightColor).toBeUndefined()
|
||||
expect(note?.noteType).toBe('Note')
|
||||
expect(note?.typeColor).toBeTruthy()
|
||||
expect(note?.typeLightColor).toBeTruthy()
|
||||
})
|
||||
|
||||
it('includes original VaultEntry in results', () => {
|
||||
|
||||
@@ -12,7 +12,7 @@ export interface NoteSearchResult extends NoteSearchResultItem {
|
||||
}
|
||||
|
||||
function toResult(e: VaultEntry, typeEntryMap: Record<string, VaultEntry>): NoteSearchResult {
|
||||
const noteType = e.isA && e.isA !== 'Note' ? e.isA : undefined
|
||||
const noteType = e.isA || undefined
|
||||
const te = typeEntryMap[e.isA ?? '']
|
||||
return {
|
||||
entry: e,
|
||||
|
||||
Reference in New Issue
Block a user