Files
tolaria/src/hooks/useTabManagement.test.ts
lucaronin ab1a1fb206 feat: add closed tab history and reopen-closed-tab support
Introduce useClosedTabHistory hook (LIFO stack, 20-entry cap, dedup)
and integrate it into useTabManagement so handleCloseTab records entries
and handleReopenClosedTab pops them to reopen at original position.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-12 00:54:23 +01:00

584 lines
20 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
import { renderHook, act } from '@testing-library/react'
import type { VaultEntry } from '../types'
import { useTabManagement, prefetchNoteContent, clearPrefetchCache } from './useTabManagement'
vi.mock('@tauri-apps/api/core', () => ({ invoke: vi.fn() }))
vi.mock('../mock-tauri', () => ({
isTauri: () => false,
mockInvoke: vi.fn().mockResolvedValue('# Mock content'),
}))
const makeEntry = (overrides: Partial<VaultEntry> = {}): VaultEntry => ({
path: '/vault/note/test.md',
filename: 'test.md',
title: 'Test Note',
isA: 'Note',
aliases: [],
belongsTo: [],
relatedTo: [],
status: 'Active',
owner: null,
cadence: null,
archived: false,
trashed: false,
trashedAt: null,
modifiedAt: 1700000000,
createdAt: 1700000000,
fileSize: 100,
snippet: '',
wordCount: 0,
relationships: {},
icon: null,
color: null,
order: null,
template: null, sort: null,
outgoingLinks: [],
...overrides,
})
const localStorageMock = (() => {
let store: Record<string, string> = {}
return {
getItem: vi.fn((key: string) => store[key] ?? null),
setItem: vi.fn((key: string, val: string) => { store[key] = val }),
removeItem: vi.fn((key: string) => { delete store[key] }),
clear: vi.fn(() => { store = {} }),
}
})()
Object.defineProperty(globalThis, 'localStorage', { value: localStorageMock })
describe('useTabManagement', () => {
beforeEach(() => {
vi.clearAllMocks()
localStorageMock.clear()
})
it('starts with no tabs and no active tab', () => {
const { result } = renderHook(() => useTabManagement())
expect(result.current.tabs).toEqual([])
expect(result.current.activeTabPath).toBeNull()
})
describe('handleSelectNote', () => {
it('opens a new tab and sets it active', async () => {
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry({ path: '/vault/note/a.md' })
await act(async () => {
await result.current.handleSelectNote(entry)
})
expect(result.current.tabs).toHaveLength(1)
expect(result.current.tabs[0].entry.path).toBe('/vault/note/a.md')
expect(result.current.activeTabPath).toBe('/vault/note/a.md')
})
it('switches to existing tab without duplicating', async () => {
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry({ path: '/vault/note/a.md' })
await act(async () => {
await result.current.handleSelectNote(entry)
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/note/b.md', title: 'B' }))
})
// Select first entry again
await act(async () => {
await result.current.handleSelectNote(entry)
})
expect(result.current.tabs).toHaveLength(2)
expect(result.current.activeTabPath).toBe('/vault/note/a.md')
})
it('handles load content failure gracefully', async () => {
const { mockInvoke } = await import('../mock-tauri')
vi.mocked(mockInvoke).mockRejectedValueOnce(new Error('fail'))
const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry()
await act(async () => {
await result.current.handleSelectNote(entry)
})
// Tab still opens with empty content on failure
expect(result.current.tabs).toHaveLength(1)
expect(result.current.tabs[0].content).toBe('')
warnSpy.mockRestore()
})
})
describe('handleCloseTab', () => {
it('removes the tab', async () => {
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry({ path: '/vault/note/a.md' })
await act(async () => {
await result.current.handleSelectNote(entry)
})
act(() => {
result.current.handleCloseTab('/vault/note/a.md')
})
expect(result.current.tabs).toHaveLength(0)
})
it('selects next tab when active tab is closed', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/c.md', title: 'C' }))
})
// Close middle tab B, should switch to C (same index)
act(() => {
result.current.handleSwitchTab('/vault/b.md')
})
act(() => {
result.current.handleCloseTab('/vault/b.md')
})
expect(result.current.tabs).toHaveLength(2)
expect(result.current.activeTabPath).toBe('/vault/c.md')
})
it('sets null active when last tab is closed', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md' }))
})
act(() => {
result.current.handleCloseTab('/vault/a.md')
})
expect(result.current.activeTabPath).toBeNull()
})
})
describe('handleSwitchTab', () => {
it('changes the active tab path', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
act(() => {
result.current.handleSwitchTab('/vault/a.md')
})
expect(result.current.activeTabPath).toBe('/vault/a.md')
})
})
describe('handleReorderTabs', () => {
it('moves a tab from one position to another', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/c.md', title: 'C' }))
})
act(() => {
result.current.handleReorderTabs(2, 0)
})
expect(result.current.tabs.map(t => t.entry.title)).toEqual(['C', 'A', 'B'])
})
it('preserves active tab after reorder', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/c.md', title: 'C' }))
})
// C is active (last opened). Move it to the front.
act(() => {
result.current.handleReorderTabs(2, 0)
})
expect(result.current.tabs.map(t => t.entry.title)).toEqual(['C', 'A', 'B'])
expect(result.current.activeTabPath).toBe('/vault/c.md')
})
it('persists tab order to localStorage', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
act(() => {
result.current.handleReorderTabs(1, 0)
})
expect(localStorageMock.setItem).toHaveBeenCalledWith(
'laputa-tab-order',
expect.any(String),
)
})
})
describe('handleReplaceActiveTab', () => {
it('replaces the active tab with a new entry', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
const replacement = makeEntry({ path: '/vault/b.md', title: 'B' })
await act(async () => {
await result.current.handleReplaceActiveTab(replacement)
})
expect(result.current.tabs).toHaveLength(1)
expect(result.current.tabs[0].entry.path).toBe('/vault/b.md')
expect(result.current.activeTabPath).toBe('/vault/b.md')
})
it('does nothing when replacing with same entry', async () => {
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry({ path: '/vault/a.md' })
await act(async () => {
await result.current.handleSelectNote(entry)
})
await act(async () => {
await result.current.handleReplaceActiveTab(entry)
})
expect(result.current.tabs).toHaveLength(1)
})
it('falls back to handleSelectNote when no active tab', async () => {
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry({ path: '/vault/a.md' })
await act(async () => {
await result.current.handleReplaceActiveTab(entry)
})
expect(result.current.tabs).toHaveLength(1)
expect(result.current.activeTabPath).toBe('/vault/a.md')
})
it('switches to existing tab instead of replacing when note is already open', async () => {
const { result } = renderHook(() => useTabManagement())
// Open two tabs: A (active) and B
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
// Switch back to A
act(() => { result.current.handleSwitchTab('/vault/a.md') })
// Replace active tab with B — but B is already open, so it should just switch
await act(async () => {
await result.current.handleReplaceActiveTab(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
// Should still have 2 tabs (not replace A), and B should be active
expect(result.current.tabs).toHaveLength(2)
expect(result.current.activeTabPath).toBe('/vault/b.md')
expect(result.current.tabs.map(t => t.entry.title)).toEqual(['A', 'B'])
})
})
describe('setTabs entry sync', () => {
it('updates tab entry via setTabs mapper (vault entry sync pattern)', async () => {
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry({ path: '/vault/a.md', trashed: false })
await act(async () => {
await result.current.handleSelectNote(entry)
})
expect(result.current.tabs[0].entry.trashed).toBe(false)
// Simulate the App.tsx sync effect: vault entry updated, sync into tab
const freshEntry = { ...entry, trashed: true, trashedAt: Date.now() / 1000 }
act(() => {
result.current.setTabs(prev => prev.map(tab =>
tab.entry.path === freshEntry.path ? { ...tab, entry: freshEntry } : tab
))
})
expect(result.current.tabs[0].entry.trashed).toBe(true)
})
it('preserves content when syncing entry', async () => {
const { result } = renderHook(() => useTabManagement())
const entry = makeEntry({ path: '/vault/a.md', archived: false })
await act(async () => {
await result.current.handleSelectNote(entry)
})
const originalContent = result.current.tabs[0].content
act(() => {
result.current.setTabs(prev => prev.map(tab =>
tab.entry.path === entry.path ? { ...tab, entry: { ...tab.entry, archived: true } } : tab
))
})
expect(result.current.tabs[0].entry.archived).toBe(true)
expect(result.current.tabs[0].content).toBe(originalContent)
})
})
describe('closeAllTabs', () => {
it('clears all tabs and active path', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
act(() => {
result.current.closeAllTabs()
})
expect(result.current.tabs).toHaveLength(0)
expect(result.current.activeTabPath).toBeNull()
})
})
describe('content prefetch cache', () => {
it('prefetch serves content to loadNoteContent (no extra IPC)', async () => {
const { mockInvoke } = await import('../mock-tauri')
vi.mocked(mockInvoke).mockResolvedValue('# Prefetched content')
prefetchNoteContent('/vault/note/pre.md')
// Allow the prefetch promise to resolve
await vi.waitFor(() => expect(vi.mocked(mockInvoke)).toHaveBeenCalledTimes(1))
// Now open the note — should use prefetched content
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/note/pre.md', title: 'Pre' }))
})
expect(result.current.tabs[0].content).toBe('# Prefetched content')
// mockInvoke was called once for prefetch, not again for handleSelectNote
expect(vi.mocked(mockInvoke)).toHaveBeenCalledTimes(1)
})
it('clearPrefetchCache prevents stale content from being served', async () => {
const { mockInvoke } = await import('../mock-tauri')
vi.mocked(mockInvoke).mockResolvedValue('# Stale')
prefetchNoteContent('/vault/note/stale.md')
await vi.waitFor(() => expect(vi.mocked(mockInvoke)).toHaveBeenCalledTimes(1))
clearPrefetchCache()
// Reset mock to return fresh content
vi.mocked(mockInvoke).mockResolvedValue('# Fresh')
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/note/stale.md', title: 'Stale' }))
})
// Should have made a new IPC call since cache was cleared
expect(result.current.tabs[0].content).toBe('# Fresh')
expect(vi.mocked(mockInvoke)).toHaveBeenCalledTimes(2)
})
it('deduplicates concurrent prefetch requests for same path', async () => {
const { mockInvoke } = await import('../mock-tauri')
vi.mocked(mockInvoke).mockResolvedValue('# Content')
prefetchNoteContent('/vault/note/dup.md')
prefetchNoteContent('/vault/note/dup.md')
prefetchNoteContent('/vault/note/dup.md')
await vi.waitFor(() => expect(vi.mocked(mockInvoke)).toHaveBeenCalledTimes(1))
})
})
describe('closed tab history', () => {
it('handleCloseTab records the closed tab in history', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
act(() => { result.current.handleCloseTab('/vault/a.md') })
expect(result.current.closedTabHistory.canReopen).toBe(true)
})
it('handleReopenClosedTab reopens the last closed tab', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
act(() => { result.current.handleCloseTab('/vault/b.md') })
await act(async () => {
await result.current.handleReopenClosedTab()
})
expect(result.current.tabs).toHaveLength(2)
expect(result.current.activeTabPath).toBe('/vault/b.md')
})
it('close 3 tabs then reopen all 3 in correct LIFO order', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/c.md', title: 'C' }))
})
// Close C, B, A
act(() => { result.current.handleCloseTab('/vault/c.md') })
act(() => { result.current.handleCloseTab('/vault/b.md') })
act(() => { result.current.handleCloseTab('/vault/a.md') })
expect(result.current.tabs).toHaveLength(0)
// Reopen: should get A first (last closed), then B, then C
await act(async () => { await result.current.handleReopenClosedTab() })
expect(result.current.activeTabPath).toBe('/vault/a.md')
await act(async () => { await result.current.handleReopenClosedTab() })
expect(result.current.activeTabPath).toBe('/vault/b.md')
await act(async () => { await result.current.handleReopenClosedTab() })
expect(result.current.activeTabPath).toBe('/vault/c.md')
expect(result.current.tabs).toHaveLength(3)
})
it('does nothing when history is empty', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleReopenClosedTab()
})
expect(result.current.tabs).toHaveLength(0)
expect(result.current.activeTabPath).toBeNull()
})
it('does not duplicate tab if note is already open', async () => {
const { result } = renderHook(() => useTabManagement())
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' }))
})
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
// Close B
act(() => { result.current.handleCloseTab('/vault/b.md') })
// Manually reopen B via handleSelectNote
await act(async () => {
await result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' }))
})
// Now try to reopen from history — B is already open, should just switch
await act(async () => {
await result.current.handleReopenClosedTab()
})
expect(result.current.tabs).toHaveLength(2)
expect(result.current.activeTabPath).toBe('/vault/b.md')
})
})
describe('rapid switching safety', () => {
it('only activates the last note when switching rapidly', async () => {
const { mockInvoke } = await import('../mock-tauri')
// Simulate slow IPC: first call resolves after second call
let resolveA: (v: string) => void
let resolveB: (v: string) => void
vi.mocked(mockInvoke)
.mockImplementationOnce(() => new Promise<string>((r) => { resolveA = r as (v: string) => void }))
.mockImplementationOnce(() => new Promise<string>((r) => { resolveB = r as (v: string) => void }))
const { result } = renderHook(() => useTabManagement())
// Start loading A (don't await — simulates rapid click)
let selectADone = false
act(() => {
result.current.handleSelectNote(makeEntry({ path: '/vault/a.md', title: 'A' })).then(() => { selectADone = true })
})
// Start loading B while A is still loading
let selectBDone = false
act(() => {
result.current.handleSelectNote(makeEntry({ path: '/vault/b.md', title: 'B' })).then(() => { selectBDone = true })
})
// B resolves first
await act(async () => { resolveB!('# B content') })
// A resolves after
await act(async () => { resolveA!('# A content') })
await vi.waitFor(() => expect(selectADone && selectBDone).toBe(true))
// Active tab should be B (the last click), not A
expect(result.current.activeTabPath).toBe('/vault/b.md')
})
})
})