57c6a4a2a4
Fixes #710 A number property like "Year: 2026" rendered as "0.0.7.234" in the note list column because the WHATWG URL parser canonicalizes integer-only hosts to IPv4 form: new URL('https://2026').hostname === '0.0.7.234'. formatChipLabel called isUrlValue('2026'), which returned true via the bare-domain branch of normalizeExternalUrl, and then asked the URL parser for the hostname. Add a single guard in normalizeExternalUrl: when the input contains no '.', reject it before the bare-domain candidate is constructed. The parseHttpUrl(trimmed) branch above already handles inputs with an explicit scheme (https://...), so the guard only narrows the bare-domain path - the path that produced the bug. Existing cases ('example.com', 'localhost') remain unaffected. Two new vitest cases cover the regression ('2026' and '0') plus a parity case for https://example.com to make sure the scheme branch is untouched.
99 lines
2.9 KiB
TypeScript
99 lines
2.9 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
import { invoke } from '@tauri-apps/api/core'
|
|
import { revealItemInDir } from '@tauri-apps/plugin-opener'
|
|
import {
|
|
copyLocalPath,
|
|
isUrlValue,
|
|
normalizeExternalUrl,
|
|
openExternalUrl,
|
|
openLocalFile,
|
|
revealLocalPath,
|
|
} from './url'
|
|
|
|
vi.mock('@tauri-apps/api/core', () => ({
|
|
invoke: vi.fn(),
|
|
}))
|
|
|
|
const originalClipboard = navigator.clipboard
|
|
|
|
function setClipboard(writeText: (value: string) => Promise<void>) {
|
|
Object.defineProperty(navigator, 'clipboard', {
|
|
configurable: true,
|
|
value: { writeText },
|
|
})
|
|
}
|
|
|
|
describe('normalizeExternalUrl', () => {
|
|
it('keeps valid http URLs and normalizes bare domains', () => {
|
|
expect(normalizeExternalUrl('https://example.com')).toBe('https://example.com')
|
|
expect(normalizeExternalUrl('https://example.com/docs')).toBe('https://example.com/docs')
|
|
expect(normalizeExternalUrl('example.com/docs')).toBe('https://example.com/docs')
|
|
})
|
|
|
|
it('rejects pure numeric values instead of treating them as bare domains', () => {
|
|
expect(normalizeExternalUrl('2026')).toBeNull()
|
|
expect(normalizeExternalUrl('0')).toBeNull()
|
|
expect(isUrlValue('2026')).toBe(false)
|
|
})
|
|
|
|
it('rejects malformed or unsupported URLs', () => {
|
|
expect(normalizeExternalUrl('https://exa mple.com')).toBeNull()
|
|
expect(normalizeExternalUrl('javascript:alert(1)')).toBeNull()
|
|
expect(normalizeExternalUrl('not a url')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('openExternalUrl', () => {
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals()
|
|
vi.restoreAllMocks()
|
|
})
|
|
|
|
it('does not ask the browser to open malformed URLs', async () => {
|
|
const open = vi.spyOn(window, 'open').mockImplementation(() => null)
|
|
|
|
await openExternalUrl('https://exa mple.com')
|
|
|
|
expect(open).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('local file actions', () => {
|
|
afterEach(() => {
|
|
Object.defineProperty(navigator, 'clipboard', {
|
|
configurable: true,
|
|
value: originalClipboard,
|
|
})
|
|
vi.unstubAllGlobals()
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
it('opens local paths through the vault-scoped backend command', async () => {
|
|
vi.stubGlobal('isTauri', true)
|
|
|
|
await openLocalFile('/vault/attachments/report.pdf', '/vault')
|
|
|
|
expect(invoke).toHaveBeenCalledWith('open_vault_file_external', {
|
|
path: '/vault/attachments/report.pdf',
|
|
vaultPath: '/vault',
|
|
})
|
|
})
|
|
|
|
it('reveals local paths through the Tauri opener plugin', async () => {
|
|
vi.stubGlobal('isTauri', true)
|
|
|
|
await revealLocalPath('/vault/notes/project.md')
|
|
|
|
expect(revealItemInDir).toHaveBeenCalledWith('/vault/notes/project.md')
|
|
})
|
|
|
|
it('copies local paths to the clipboard', async () => {
|
|
const writeText = vi.fn().mockResolvedValue(undefined)
|
|
setClipboard(writeText)
|
|
|
|
await copyLocalPath('/vault/Folder With Spaces/项目.md')
|
|
|
|
expect(writeText).toHaveBeenCalledWith('/vault/Folder With Spaces/项目.md')
|
|
})
|
|
})
|