3ea175eec5
BlockNote's SuggestionMenu uses item.title as React key, causing duplicate rendering and broken arrow-key navigation when multiple notes share the same title. Fix by: - Adding path-based deduplication to filter out duplicate entries - Disambiguating same-title notes with parent folder name (e.g. "Standup (work)") - Deduplicating aliases within each item (filename vs entry.aliases overlap) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
60 lines
1.8 KiB
TypeScript
60 lines
1.8 KiB
TypeScript
export const MIN_QUERY_LENGTH = 2
|
|
export const MAX_RESULTS = 20
|
|
|
|
export interface WikilinkBaseItem {
|
|
title: string
|
|
aliases: string[]
|
|
group: string
|
|
entryTitle: string
|
|
path: string
|
|
}
|
|
|
|
/**
|
|
* Pre-filter wikilink suggestion candidates using case-insensitive substring
|
|
* matching on title, aliases, and group. This avoids creating expensive
|
|
* onItemClick closures for thousands of entries that won't match anyway.
|
|
*
|
|
* Returns [] when query is shorter than MIN_QUERY_LENGTH.
|
|
*/
|
|
export function preFilterWikilinks<T extends WikilinkBaseItem>(
|
|
items: T[],
|
|
query: string,
|
|
): T[] {
|
|
if (query.length < MIN_QUERY_LENGTH) return []
|
|
const lowerQuery = query.toLowerCase()
|
|
return items.filter(item =>
|
|
item.title.toLowerCase().includes(lowerQuery) ||
|
|
item.aliases.some(a => a.toLowerCase().includes(lowerQuery)) ||
|
|
item.group.toLowerCase().includes(lowerQuery)
|
|
)
|
|
}
|
|
|
|
/** Remove duplicate items by path, keeping the first occurrence. */
|
|
export function deduplicateByPath<T extends { path: string }>(items: T[]): T[] {
|
|
const seen = new Set<string>()
|
|
return items.filter(item => {
|
|
if (seen.has(item.path)) return false
|
|
seen.add(item.path)
|
|
return true
|
|
})
|
|
}
|
|
|
|
/**
|
|
* When multiple items share the same title, append the parent folder name
|
|
* so the user can distinguish them and BlockNote gets unique React keys.
|
|
*/
|
|
export function disambiguateTitles<T extends { title: string; path: string }>(
|
|
items: T[],
|
|
): T[] {
|
|
const titleCounts = new Map<string, number>()
|
|
for (const item of items) {
|
|
titleCounts.set(item.title, (titleCounts.get(item.title) ?? 0) + 1)
|
|
}
|
|
return items.map(item => {
|
|
if ((titleCounts.get(item.title) ?? 0) <= 1) return item
|
|
const parts = item.path.split('/')
|
|
const folder = parts.length >= 2 ? parts[parts.length - 2] : ''
|
|
return { ...item, title: `${item.title} (${folder})` }
|
|
})
|
|
}
|