davidl/tolaria
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: recover invalid insertion depth transforms

Browse Source
This commit is contained in:
lucaronin
2026-05-23 16:11:20 +02:00
parent 5bb3fe0550
commit f0fb7b7418
3 changed files with 41 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
src/components/richEditorTransformErrorRecoveryExtension.test.ts
View File

@@ -32,6 +32,19 @@ function createView(error?: Error) {
return { currentDoc, dispatch, view }
}
function expectDocumentRepairRecovery(error: Error, reason: string) {
const { currentDoc, view } = createView(error)
const recoverDocument = vi.fn()
installRichEditorTransformErrorRecovery(view, { recoverDocument })
expect(() => view.dispatch({ before: currentDoc })).not.toThrow()
expect(recoverDocument).toHaveBeenCalledTimes(1)
expect(trackEvent).toHaveBeenCalledWith('rich_editor_transform_error_recovered', {
reason,
})
}
beforeEach(() => {
vi.spyOn(console, 'warn').mockImplementation(() => {})
})
@@ -48,6 +61,9 @@ describe('isRecoverableEditorTransformError', () => {
expect(isRecoverableEditorTransformError(new RangeError(
'Invalid content for node blockContainer: <paragraph("Procedures are long-running"), blockGroup(blockContainer(bulletListItem("Step")))>',
))).toBe(true)
expect(isRecoverableEditorTransformError(new RangeError(
'Inserted content deeper than insertion position',
))).toBe(true)
expect(isRecoverableEditorTransformError(new RangeError(
'Index 1 out of range for <tableRow(tableCell(tableParagraph("A")))>',
))).toBe(true)
@@ -84,35 +100,26 @@ describe('installRichEditorTransformErrorRecovery', () => {
})
it('recovers invalid-content schema transactions from mixed paragraph and list editing', () => {
const schemaError = new RangeError(
'Invalid content for node blockContainer: <paragraph("Procedures are long-running"), blockGroup(blockContainer(bulletListItem("Step")))>',
expectDocumentRepairRecovery(
new RangeError(
'Invalid content for node blockContainer: <paragraph("Procedures are long-running"), blockGroup(blockContainer(bulletListItem("Step")))>',
),
'transform_error',
)
const { currentDoc, view } = createView(schemaError)
const recoverDocument = vi.fn()
installRichEditorTransformErrorRecovery(view, { recoverDocument })
expect(() => view.dispatch({ before: currentDoc })).not.toThrow()
expect(recoverDocument).toHaveBeenCalledTimes(1)
expect(trackEvent).toHaveBeenCalledWith('rich_editor_transform_error_recovered', {
reason: 'transform_error',
})
})
it('recovers table selection transactions whose target row changed underneath BlockNote', () => {
const tableError = new RangeError(
'Index 1 out of range for <tableRow(tableCell(tableParagraph("A")))>',
expectDocumentRepairRecovery(
new RangeError('Index 1 out of range for <tableRow(tableCell(tableParagraph("A")))>'),
'table_position_out_of_range',
)
const { currentDoc, view } = createView(tableError)
const recoverDocument = vi.fn()
})
installRichEditorTransformErrorRecovery(view, { recoverDocument })
expect(() => view.dispatch({ before: currentDoc })).not.toThrow()
expect(recoverDocument).toHaveBeenCalledTimes(1)
expect(trackEvent).toHaveBeenCalledWith('rich_editor_transform_error_recovered', {
reason: 'table_position_out_of_range',
})
it('recovers invalid insertion-depth transactions after note switching and saves', () => {
expectDocumentRepairRecovery(
new RangeError('Inserted content deeper than insertion position'),
'invalid_insertion_depth',
)
})
it('keeps non-ProseMirror dispatch failures visible', () => {