feat: unify note search into shared NoteSearchList + useNoteSearch

Extract a single NoteSearchList component and useNoteSearch hook that
all three note-search UIs now share: wiki-link autocomplete, relations
autocomplete, and Cmd+P quick open. All show note name + type badge
consistently, with identical keyboard navigation behavior.

- NoteSearchList: reusable result list with title + type badge
- useNoteSearch: fuzzy search + arrow-key navigation hook
- WikilinkSuggestionMenu: now wraps NoteSearchList
- QuickOpenPalette: uses useNoteSearch + NoteSearchList
- InlineAddNote: replaces <datalist> with proper search dropdown
- AddRelationshipForm: replaces <datalist> with NoteTargetInput
- InspectorPanels code health improved from 8.99 to 9.04

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/hooks/useNoteSearch.test.ts

@@ -0,0 +1,174 @@
+import { describe, it, expect, vi } from 'vitest'
+import { renderHook, act } from '@testing-library/react'
+import { useNoteSearch } from './useNoteSearch'
+import type { VaultEntry } from '../types'
+
+const makeEntry = (overrides: Partial<VaultEntry> = {}): VaultEntry => ({
+  path: '/vault/note/test.md',
+  filename: 'test.md',
+  title: 'Test Note',
+  isA: 'Note',
+  aliases: [],
+  belongsTo: [],
+  relatedTo: [],
+  status: 'Active',
+  owner: null,
+  cadence: null,
+  archived: false,
+  trashed: false,
+  trashedAt: null,
+  modifiedAt: 1700000000,
+  createdAt: 1700000000,
+  fileSize: 100,
+  snippet: '',
+  relationships: {},
+  icon: null,
+  color: null,
+  order: null,
+  ...overrides,
+})
+
+const entries: VaultEntry[] = [
+  makeEntry({ path: '/vault/a.md', title: 'Alpha Project', isA: 'Project', modifiedAt: 1700000003 }),
+  makeEntry({ path: '/vault/b.md', title: 'Beta Notes', isA: 'Note', modifiedAt: 1700000002 }),
+  makeEntry({ path: '/vault/c.md', title: 'Gamma Experiment', isA: 'Experiment', modifiedAt: 1700000001 }),
+]
+
+describe('useNoteSearch', () => {
+  it('returns entries sorted by modifiedAt when query is empty', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+    expect(result.current.results.map((r) => r.title)).toEqual([
+      'Alpha Project',
+      'Beta Notes',
+      'Gamma Experiment',
+    ])
+  })
+
+  it('filters entries by fuzzy match', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, 'alpha'))
+    expect(result.current.results).toHaveLength(1)
+    expect(result.current.results[0].title).toBe('Alpha Project')
+  })
+
+  it('returns empty results when query has no matches', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, 'zzzzzzz'))
+    expect(result.current.results).toHaveLength(0)
+  })
+
+  it('respects maxResults', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, '', 2))
+    expect(result.current.results).toHaveLength(2)
+  })
+
+  it('includes noteType for non-Note entries', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+    const project = result.current.results.find((r) => r.title === 'Alpha Project')
+    expect(project?.noteType).toBe('Project')
+    expect(project?.typeColor).toBeTruthy()
+  })
+
+  it('excludes noteType for Note entries', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+    const note = result.current.results.find((r) => r.title === 'Beta Notes')
+    expect(note?.noteType).toBeUndefined()
+    expect(note?.typeColor).toBeUndefined()
+  })
+
+  it('includes original VaultEntry in results', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+    expect(result.current.results[0].entry).toBe(entries[0])
+  })
+
+  it('starts with selectedIndex 0', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+    expect(result.current.selectedIndex).toBe(0)
+  })
+
+  it('resets selectedIndex when query changes', () => {
+    let query = ''
+    const { result, rerender } = renderHook(() => useNoteSearch(entries, query))
+
+    act(() => {
+      result.current.setSelectedIndex(2)
+    })
+    expect(result.current.selectedIndex).toBe(2)
+
+    query = 'alpha'
+    rerender()
+    expect(result.current.selectedIndex).toBe(0)
+  })
+
+  it('handleKeyDown moves selection down on ArrowDown', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+
+    act(() => {
+      result.current.handleKeyDown(
+        new KeyboardEvent('keydown', { key: 'ArrowDown' }),
+      )
+    })
+    expect(result.current.selectedIndex).toBe(1)
+  })
+
+  it('handleKeyDown moves selection up on ArrowUp', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+
+    act(() => {
+      result.current.setSelectedIndex(2)
+    })
+    act(() => {
+      result.current.handleKeyDown(
+        new KeyboardEvent('keydown', { key: 'ArrowUp' }),
+      )
+    })
+    expect(result.current.selectedIndex).toBe(1)
+  })
+
+  it('handleKeyDown clamps selection at boundaries', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+
+    // Can't go below 0
+    act(() => {
+      result.current.handleKeyDown(
+        new KeyboardEvent('keydown', { key: 'ArrowUp' }),
+      )
+    })
+    expect(result.current.selectedIndex).toBe(0)
+
+    // Can't go above last index
+    act(() => {
+      result.current.setSelectedIndex(2)
+    })
+    act(() => {
+      result.current.handleKeyDown(
+        new KeyboardEvent('keydown', { key: 'ArrowDown' }),
+      )
+    })
+    expect(result.current.selectedIndex).toBe(2)
+  })
+
+  it('selectedEntry reflects current selection', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+    expect(result.current.selectedEntry).toBe(entries[0])
+
+    act(() => {
+      result.current.setSelectedIndex(1)
+    })
+    expect(result.current.selectedEntry).toBe(entries[1])
+  })
+
+  it('selectedEntry is null when no results', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, 'zzzzzzz'))
+    expect(result.current.selectedEntry).toBeNull()
+  })
+
+  it('does not prevent default for non-arrow keys', () => {
+    const { result } = renderHook(() => useNoteSearch(entries, ''))
+    const event = new KeyboardEvent('keydown', { key: 'Enter' })
+    const preventDefaultSpy = vi.spyOn(event, 'preventDefault')
+
+    act(() => {
+      result.current.handleKeyDown(event)
+    })
+    expect(preventDefaultSpy).not.toHaveBeenCalled()
+  })
+})