davidl/tolaria
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: stabilize global search keyboard navigation

Browse Source
This commit is contained in:
lucaronin
2026-05-27 11:13:45 +02:00
parent 4296977fe3
commit bdb9fabfd0
3 changed files with 301 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
tests/smoke/keyboard-command-routing.spec.ts
View File

@@ -14,6 +14,13 @@ import {
let tempVaultDir: string
const GLOBAL_SEARCH_INPUT = 'input[placeholder="Search in all notes..."]'
const GLOBAL_SEARCH_RESULTS = [
{ title: 'First Search Result', path: '/vault/first-search-result.md', snippet: 'first', score: 1, note_type: null },
{ title: 'Second Search Result', path: '/vault/second-search-result.md', snippet: 'second', score: 0.9, note_type: null },
{ title: 'Third Search Result', path: '/vault/third-search-result.md', snippet: 'third', score: 0.8, note_type: null },
]
async function openAlphaProjectInEditor(page: Page) {
await openFixtureVaultDesktopHarness(page, tempVaultDir)
await page.getByText('Alpha Project', { exact: true }).first().click()
@@ -68,6 +75,28 @@ async function dispatchAppCommand(page: Page, id: string): Promise<void> {
}, id)
}
async function installGlobalSearchResultsHarness(page: Page): Promise<void> {
await page.waitForFunction(() => Boolean(window.__mockHandlers?.search_vault))
await page.evaluate((results) => {
type Handler = (args?: Record<string, unknown>) => unknown
const handlers = window.__mockHandlers as Record<string, Handler>
Object.defineProperty(window, '__mockHandlers', {
configurable: true,
get: () => handlers,
set: (nextHandlers) => Object.assign(handlers, nextHandlers),
})
handlers.search_vault = () => ({ results, elapsed_ms: 1 })
}, GLOBAL_SEARCH_RESULTS)
}
function searchResultRow(page: Page, title: string) {
return page.locator('[role="option"]').filter({ hasText: title }).first()
}
async function expectSelectedSearchResult(page: Page, title: string): Promise<void> {
await expect(searchResultRow(page, title)).toHaveClass(/bg-accent/)
}
test.describe('keyboard command routing', () => {
test.beforeEach(() => {
tempVaultDir = createFixtureVaultCopy()
@@ -135,6 +164,35 @@ test.describe('keyboard command routing', () => {
await expect(page.locator('input[placeholder="Search notes..."]')).toBeFocused()
})
test('global search arrow keys move one result at a time @smoke', async ({ page }) => {
await openFixtureVaultDesktopHarness(page, tempVaultDir)
await installGlobalSearchResultsHarness(page)
await page.locator('body').click()
await dispatchShortcutEvent(page, {
key: 'f',
code: 'KeyF',
ctrlKey: false,
metaKey: true,
shiftKey: true,
altKey: false,
bubbles: true,
cancelable: true,
})
const input = page.locator(GLOBAL_SEARCH_INPUT)
await expect(input).toBeVisible({ timeout: 5_000 })
await input.fill('search')
await expect(searchResultRow(page, 'Third Search Result')).toBeVisible({ timeout: 5_000 })
await expectSelectedSearchResult(page, 'First Search Result')
await page.keyboard.press('ArrowDown')
await expectSelectedSearchResult(page, 'Second Search Result')
await page.keyboard.press('ArrowDown')
await expectSelectedSearchResult(page, 'Third Search Result')
await page.keyboard.press('ArrowUp')
await expectSelectedSearchResult(page, 'Second Search Result')
})
test('desktop menu-command bridge toggles organized state through the shared command path @smoke', async ({ page }) => {
await openAlphaProjectInEditor(page)