From 9fa1c52a96b829a20fd5bda97f6ef2efec62e9b0 Mon Sep 17 00:00:00 2001 From: Test Date: Sat, 4 Apr 2026 22:25:55 +0200 Subject: [PATCH] fix: wrap SearchPanel Enter keyDown in act() to prevent flaky test The 'selects result on Enter' test could fail intermittently because fireEvent.keyDown(window) fired before the useEffect re-registered the keyboard handler after results loaded. Wrapping in act() ensures effects are flushed before the event dispatches. Co-Authored-By: Claude Opus 4.6 (1M context) --- src/components/SearchPanel.test.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/components/SearchPanel.test.tsx b/src/components/SearchPanel.test.tsx index 47f739ca..c1280a51 100644 --- a/src/components/SearchPanel.test.tsx +++ b/src/components/SearchPanel.test.tsx @@ -1,4 +1,4 @@ -import { render, screen, fireEvent, waitFor } from '@testing-library/react' +import { render, screen, fireEvent, waitFor, act } from '@testing-library/react' import { describe, it, expect, vi, beforeEach } from 'vitest' import { SearchPanel } from './SearchPanel' import type { VaultEntry } from '../types' @@ -239,12 +239,12 @@ describe('SearchPanel', () => { expect(screen.getByText('How to Design AI-first APIs')).toBeInTheDocument() }) - fireEvent.keyDown(window, { key: 'Enter' }) - - await waitFor(() => { - expect(onSelectNote).toHaveBeenCalledWith(MOCK_ENTRIES[0]) - expect(onClose).toHaveBeenCalled() + await act(async () => { + fireEvent.keyDown(window, { key: 'Enter' }) }) + + expect(onSelectNote).toHaveBeenCalledWith(MOCK_ENTRIES[0]) + expect(onClose).toHaveBeenCalled() }) it('shows result count and elapsed time', async () => {