From 79fe2d9e6d9cc2cdad0456194b0f7d7130351db1 Mon Sep 17 00:00:00 2001
From: lucaronin <luca.rossi.917@gmail.com>
Date: Tue, 24 Feb 2026 10:29:23 +0100
Subject: [PATCH] fix: improve device flow 404 error with setup instructions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The GitHub App (Ov23liCuBz7Z5hKk6T8c) does not have Device
authorization flow enabled — GitHub returns 404. The error message
now includes specific setup steps so the user can fix the
configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src-tauri/src/github.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src-tauri/src/github.rs b/src-tauri/src/github.rs
index fa1bc841..6f930fa5 100644
--- a/src-tauri/src/github.rs
+++ b/src-tauri/src/github.rs
@@ -2,7 +2,9 @@ use serde::{Deserialize, Serialize};
 use std::path::Path;
 use std::process::Command;
 
-/// GitHub OAuth App client ID. Replace with your registered GitHub App's client_id.
+/// GitHub App client ID for OAuth device flow.
+/// To set up: GitHub Settings → Developer settings → GitHub Apps → New GitHub App.
+/// Enable "Device authorization flow" under Optional features. Webhook can be disabled.
 const GITHUB_CLIENT_ID: &str = "Ov23liCuBz7Z5hKk6T8c";
 
 #[derive(Debug, Serialize, Deserialize, Clone)]
@@ -186,7 +188,8 @@ async fn github_device_flow_start_with_base(base_url: &str) -> Result<DeviceFlow
         let body = response.text().await.unwrap_or_default();
         if status.as_u16() == 404 {
             return Err(
-                "GitHub device flow not available. The OAuth App may not have device flow enabled."
+                "GitHub device flow not available. Ensure a GitHub App is registered with \
+                 'Device authorization flow' enabled (Settings → Developer settings → GitHub Apps)."
                     .to_string(),
             );
         }
@@ -818,6 +821,7 @@ mod tests {
         assert!(result.is_err());
         let err = result.unwrap_err();
         assert!(err.contains("device flow not available"));
+        assert!(err.contains("Device authorization flow"));
     }
 
     #[tokio::test]