fix: clear codacy object injection highs

This commit is contained in:
lucaronin
2026-05-07 20:44:45 +02:00
parent 8d35fbcba3
commit 5965d5f23f
98 changed files with 952 additions and 559 deletions

View File

@@ -33,8 +33,8 @@ function measureDuration(
start: keyof NoteOpenTrace['marks'] | 'startedAt',
end: keyof NoteOpenTrace['marks'],
): number | null {
const startTime = start === 'startedAt' ? trace.startedAt : trace.marks[start]
const endTime = trace.marks[end]
const startTime = start === 'startedAt' ? trace.startedAt : Reflect.get(trace.marks, start) as number | undefined
const endTime = Reflect.get(trace.marks, end) as number | undefined
if (startTime === undefined || endTime === undefined) return null
return endTime - startTime
}
@@ -61,7 +61,7 @@ export function markNoteOpenTrace(path: string, stage: NoteOpenStage): void {
if (!canMeasurePerformance()) return
const trace = inFlightNoteOpens.get(path)
if (!trace) return
trace.marks[stage] = performance.now()
Reflect.set(trace.marks, stage, performance.now())
}
export function finishNoteOpenTrace(path: string): void {
@@ -69,8 +69,9 @@ export function finishNoteOpenTrace(path: string): void {
const trace = inFlightNoteOpens.get(path)
if (!trace) return
trace.marks.editorSwapped = performance.now()
const total = trace.marks.editorSwapped - trace.startedAt
Reflect.set(trace.marks, 'editorSwapped', performance.now())
const editorSwappedAt = Reflect.get(trace.marks, 'editorSwapped') as number
const total = editorSwappedAt - trace.startedAt
const beforeNavigate = measureDuration(trace, 'beforeNavigateStart', 'beforeNavigateEnd')
const freshnessCheck = measureDuration(trace, 'freshnessCheckStart', 'freshnessCheckEnd')
const contentLoad = measureDuration(trace, 'contentLoadStart', 'contentLoadEnd')
@@ -85,7 +86,7 @@ export function finishNoteOpenTrace(path: string): void {
+ `freshnessCheck=${formatDuration(freshnessCheck)} `
+ `contentLoad=${formatDuration(contentLoad)} `
+ `editorSwap=${formatDuration(editorSwap)} `
+ `cache=${trace.marks.cacheReady !== undefined ? 'hit' : 'miss'}`,
+ `cache=${Reflect.get(trace.marks, 'cacheReady') !== undefined ? 'hit' : 'miss'}`,
)
inFlightNoteOpens.delete(path)
}