davidl/tolaria
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: distinguish new notes (green dot) from modified notes (orange dot)

Browse Source 
New notes created in-session show a green dot; existing notes with
uncommitted git changes show an orange dot. Saving a new note clears
the green dot; git commit clears the orange dot.

Introduces NoteStatus type ('new' | 'modified' | 'clean'), extracts
useNewNoteTracker hook and resolveNoteStatus pure function, and adds
onNoteSaved callback to useEditorSave for clearing new-note tracking.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
lucaronin
2026-02-24 15:54:24 +01:00
parent 0e9de3c1e2
commit 4f03751da5
16 changed files with 380 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/hooks/useEditorSave.test.ts
View File

@@ -107,10 +107,13 @@ describe('useEditorSave', () => {
})
})
it('calls onAfterSave callback after successful save', async () => {
const onAfterSave = vi.fn()
it.each([
{ name: 'onAfterSave', key: 'onAfterSave' as const },
{ name: 'onNoteSaved', key: 'onNoteSaved' as const },
])('calls $name callback after successful save', async ({ key }) => {
const cb = vi.fn()
const { result } = renderHook(() =>
useEditorSave({ updateVaultContent, setTabs, setToastMessage, onAfterSave })
useEditorSave({ updateVaultContent, setTabs, setToastMessage, [key]: cb })
)
act(() => {
@@ -121,7 +124,7 @@ describe('useEditorSave', () => {
await result.current.handleSave()
})
expect(onAfterSave).toHaveBeenCalledOnce()
expect(cb).toHaveBeenCalled()
})
it('calls onAfterSave even when nothing is pending (e.g. after rename)', async () => {
@@ -139,12 +142,15 @@ describe('useEditorSave', () => {
expect(onAfterSave).toHaveBeenCalledOnce()
})
it('does not call onAfterSave when save fails', async () => {
it.each([
{ name: 'onAfterSave', key: 'onAfterSave' as const },
{ name: 'onNoteSaved', key: 'onNoteSaved' as const },
])('does not call $name when save fails', async ({ key }) => {
mockInvokeFn.mockRejectedValueOnce(new Error('Disk full'))
const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
const onAfterSave = vi.fn()
const cb = vi.fn()
const { result } = renderHook(() =>
useEditorSave({ updateVaultContent, setTabs, setToastMessage, onAfterSave })
useEditorSave({ updateVaultContent, setTabs, setToastMessage, [key]: cb })
)
act(() => {
@@ -155,7 +161,7 @@ describe('useEditorSave', () => {
await result.current.handleSave()
})
expect(onAfterSave).not.toHaveBeenCalled()
expect(cb).not.toHaveBeenCalled()
consoleSpy.mockRestore()
})