davidl/tolaria
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: prevent whiteboard dialog crash

Browse Source
This commit is contained in:
lucaronin
2026-05-13 12:42:37 +02:00
parent 09978cf8e5
commit 2a5ebcf73d
2 changed files with 72 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/smoke/tldraw-whiteboard-notes.spec.ts
View File

@@ -226,6 +226,28 @@ test('embedded tldraw dialogs appear and release focus when closed', async ({ pa
await expectNoEditorNodeSelection(page)
})
test('embedded tldraw insert embed dialog opens without crashing the note', async ({ page }) => {
await openNote(page, 'Whiteboard Embed')
const whiteboard = page.locator('.tldraw-whiteboard')
await expect(whiteboard).toBeVisible({ timeout: 20_000 })
await page.getByTestId('main-menu.button').click()
await page.getByTestId('main-menu.insert-embed').click()
const embedDialog = page.locator('.tldraw-whiteboard .tlui-dialog__content')
await expect(embedDialog).toBeVisible({ timeout: 5_000 })
await expect(embedDialog).toContainText('Insert embed')
await expect(page.locator('.error-boundary')).toHaveCount(0)
const dialogBox = await embedDialog.boundingBox()
const boardBox = await whiteboard.boundingBox()
expect(dialogBox).not.toBeNull()
expect(boardBox).not.toBeNull()
expect(dialogBox!.x).toBeGreaterThanOrEqual(boardBox!.x)
expect(dialogBox!.x + dialogBox!.width).toBeLessThanOrEqual(boardBox!.x + boardBox!.width)
})
test(TAURI_CONTEXT_MENU_TEST, async ({ page }) => {
await openNote(page, 'Whiteboard Embed')